[ 
https://issues.apache.org/jira/browse/HBASE-16970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622723#comment-15622723
 ] 

Yu Li commented on HBASE-16970:
-------------------------------

Thanks for the patch [~jkleckner], this cooperates one of the points mentioned 
in HBASE-16973.

Regarding the patch, what about change it to something like below?
{code}
  /**
   * -1 means no caching specified and 
HConstants.DEFAULT_HBASE_CLIENT_SCANNER_CACHING will be used
   */
{code}

> Clarify misleading Scan.java comment about caching
> --------------------------------------------------
>
>                 Key: HBASE-16970
>                 URL: https://issues.apache.org/jira/browse/HBASE-16970
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jim Kleckner
>            Priority: Trivial
>              Labels: documentation, patch
>         Attachments: HBASE-16970.patch
>
>
> The Scan class has an integer field, caching, that defaults to -1.  The 
> meaning of -1 is that the option was not overriden (aka not set) and 
> therefore that the default configuration should be used.
> This trivial patch corrects the comment of that field to reflect this meaning 
> rather than misleading the reader to believe that caching is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to