[
https://issues.apache.org/jira/browse/HBASE-17034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ChiaPing Tsai updated HBASE-17034:
----------------------------------
Assignee: ChiaPing Tsai
Fix Version/s: 2.0.0
Affects Version/s: 2.0.0
Status: Patch Available (was: Open)
> avoid unnecessary Get copy in HTable#exist
> ------------------------------------------
>
> Key: HBASE-17034
> URL: https://issues.apache.org/jira/browse/HBASE-17034
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: ChiaPing Tsai
> Assignee: ChiaPing Tsai
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-17034.v0.patch
>
>
> {code:title=HTable.java|borderStyle=solid}
> private Result get(Get get, final boolean checkExistenceOnly) throws
> IOException {
> if (get.isCheckExistenceOnly() != checkExistenceOnly ||
> get.getConsistency() == null) {
> get = ReflectionUtils.newInstance(get.getClass(), get);
> get.setCheckExistenceOnly(checkExistenceOnly);
> if (get.getConsistency() == null){
> get.setConsistency(defaultConsistency);
> }
> }
> ...
> }
> {code}
> Can the passed Get be modified? If so, we can just change the passed Get. If
> not, we can record the values returned by isCheckExistenceOnly() and
> getConsistency() for avoiding the Get copy.
> It seems to me that it is ok to modify the passed Get.
> Any comment? Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
