[
https://issues.apache.org/jira/browse/HBASE-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167061#comment-13167061
]
Hadoop QA commented on HBASE-5007:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506882/HBase_0.92_HBASE-5007.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -160 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 75 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/486//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/486//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/486//console
This message is automatically generated.
> HBaseAdmin.stopRegionServer do not stop the region server
> ---------------------------------------------------------
>
> Key: HBASE-5007
> URL: https://issues.apache.org/jira/browse/HBASE-5007
> Project: HBase
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.0
>
> Attachments: HBase_0.92_HBASE-5007.patch
>
>
> Please running this example:
> public class Test {
> public static void main(String[] args) throws Exception {
> HBaseAdmin admin = new HBaseAdmin(HBaseConfiguration.create());
> admin.stopRegionServer("your.rs.hostname:60020");
> }
> }
> then, you can see:
> Exception in thread "main" java.lang.RuntimeException: The interface
> org.apache.hadoop.hbase.Stoppable
> at org.apache.hadoop.hbase.ipc.Invocation.<init>(Invocation.java:61)
> at
> org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:151)
> at $Proxy2.stop(Unknown Source)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.stopRegionServer(HBaseAdmin.java:1492)
> at Test.main(Test.java:7)
> Caused by: java.lang.NoSuchFieldException: VERSION
> at java.lang.Class.getField(Class.java:1520)
> at org.apache.hadoop.hbase.ipc.Invocation.<init>(Invocation.java:57)
> ... 4 more
> When invoking the "HBaseAdmin.stopRegionServer" method，
> we obtain a "proxy" for org.apache.hadoop.hbase.ipc.HRegionInterface，
> (HRegionInterface extends org.apache.hadoop.hbase.Stoppable)
> but the "stop" method declared in Stoppable.
> In the constructor of "org.apache.hadoop.hbase.ipc.Invocation"，
> the "method" argument is "public abstract void
> org.apache.hadoop.hbase.Stoppable.stop(java.lang.String)"，
> so, "method.getDeclaringClass()" is "org.apache.hadoop.hbase.Stoppable"，
> but, the "Stoppable" interface no "VERSION" field.
> [fix suggestion]:
> Override the "stop" method in org.apache.hadoop.hbase.ipc.HRegionInterface as
> follows:
> ==================================
> @Override
> public void stop(String why);
> of courese, another attempt is ok.
> (e.g. declare "VERSION" field in Stoppable interface，
> then modify some code fragment of Invocation and
> org.apache.hadoop.hbase.ipc.WritableRpcEngine.Server)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
