[
https://issues.apache.org/jira/browse/HBASE-17021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646866#comment-15646866
]
ramkrishna.s.vasudevan commented on HBASE-17021:
------------------------------------------------
Some more questions on the FanoutDFSOutputStream
{code}
int trailingPartialChunkLen = dataLen % summer.getBytesPerChecksum();
ByteBuf newBuf =
alloc.directBuffer().ensureWritable(trailingPartialChunkLen);
if (trailingPartialChunkLen != 0) {
buf.readerIndex(dataLen - trailingPartialChunkLen).readBytes(newBuf,
trailingPartialChunkLen);
}
buf.release();
this.buf = newBuf;
{code}
This does a copy I believe. And in case of netty bytebufs as and when we write
data to it how does the bytebuf grow? How costly are those operations?
> Use RingBuffer to reduce the contention in AsyncFSWAL
> -----------------------------------------------------
>
> Key: HBASE-17021
> URL: https://issues.apache.org/jira/browse/HBASE-17021
> Project: HBase
> Issue Type: Sub-task
> Components: wal
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: AsyncWAL_disruptor_7.patch, HBASE-17021-v1.patch,
> HBASE-17021-v2.patch, HBASE-17021.patch
>
>
> The WALPE result in HBASE-16890 shows that with disruptor's RingBuffer we can
> get a better performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
