[
https://issues.apache.org/jira/browse/HBASE-16962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650073#comment-15650073
]
Anoop Sam John commented on HBASE-16962:
----------------------------------------
Patch looks good overall.
Not directly on ur patch
{code}
protected InternalScanner preCreateCoprocScanner(final CompactionRequest
request,
final ScanType scanType, final long earliestPutTs, final
List<StoreFileScanner> scanners,
User user) throws IOException {
{code}
Seems the code flow dont use this at all.. Finally we pass null as User always
to the CP area. A miss? Or we dont mind the user here? ANy idea [~tedyu]?
> Add readPoint to preCompactScannerOpen() and preFlushScannerOpen() API
> ----------------------------------------------------------------------
>
> Key: HBASE-16962
> URL: https://issues.apache.org/jira/browse/HBASE-16962
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Thiruvel Thirumoolan
> Assignee: Thiruvel Thirumoolan
> Attachments: HBASE-16962.master.001.patch,
> HBASE-16962.master.002.patch, HBASE-16962.master.003.patch,
> HBASE-16962.master.004.patch, HBASE-16962.rough.patch
>
>
> Similar to HBASE-15759, I would like to add readPoint to the
> preCompactScannerOpen() API.
> I have a CP where I create a StoreScanner() as part of the
> preCompactScannerOpen() API. I need the readpoint which was obtained in
> Compactor.compact() method to be consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
