[
https://issues.apache.org/jira/browse/HBASE-17053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15650694#comment-15650694
]
ramkrishna.s.vasudevan commented on HBASE-17053:
------------------------------------------------
{code}
@Override
213 public void close() {
214 running = false;
215 interrupt();
216 }
{code}
Does the HRS call the LogRoller's close now? Rest looks good to me +1.
> Remove LogRollerExitedChecker
> -----------------------------
>
> Key: HBASE-17053
> URL: https://issues.apache.org/jira/browse/HBASE-17053
> Project: HBase
> Issue Type: Sub-task
> Components: wal
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17053-v1.patch, HBASE-17053.patch
>
>
> Now the LogRoll may exit before WAL exit but we will still write some close
> event to WAL when shutting down RS. And for AsyncFSWAL, we will open a new
> wal writer when error occur. If LogRoller has already exited then AsyncFSWAL
> will wait for ever and cause RS to hang.
> It does not make sense to quit LogRoller ahead of WAL, this jira aims to
> change the shutdown order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
