[ 
https://issues.apache.org/jira/browse/HBASE-17082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665506#comment-15665506
 ] 

ChiaPing Tsai edited comment on HBASE-17082 at 11/15/16 12:25 AM:
------------------------------------------------------------------

Thanks for your suggestion [~stack] [~enis]

Please see the unit tests from 
[HBASE-16169|https://builds.apache.org/job/PreCommit-HBASE-Build/4416/artifact/patchprocess/patch-unit-hbase-client.txt]
 or 
[HBASE-17076|https://builds.apache.org/job/PreCommit-HBASE-Build/4444/artifact/patchprocess/patch-unit-hbase-client.txt].
 If the patch try to modify the hbase-protocol-shaded module, this issue will 
appear.

Sorry for any confusion.


was (Author: chia7712):
Thanks for your suggestion [~stack][~enis]

Please see the unit tests from 
[HBASE-16169|https://builds.apache.org/job/PreCommit-HBASE-Build/4416/artifact/patchprocess/patch-unit-hbase-client.txt]
 or 
[HBASE-17076|https://builds.apache.org/job/PreCommit-HBASE-Build/4444/artifact/patchprocess/patch-unit-hbase-client.txt].
 If the patch try to modify the hbase-protocol-shaded module, this issue will 
appear.

Sorry for any confusion.

> ForeignExceptionUtil isn’t packaged when building shaded protocol with 
> -Pcompile-protobuf
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-17082
>                 URL: https://issues.apache.org/jira/browse/HBASE-17082
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17082.v0.patch, HBASE-17082.v1.patch, 
> patch-unit-hbase-client (after v1.patch).txt, patch-unit-hbase-server (after 
> v1.patch).txt
>
>
> The source folder will be replaced from src/main/java to 
> project.build.directory/protoc-generated-sources when building shaded 
> protocol with -Pcompile-protobuf, but we do not copy the 
> ForeignExceptionUtil. So the final jar lacks the ForeignExceptionUtil and it 
> causes the test error for hbase-client and hbase-server.
> {noformat}
> [ERROR] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[169,36]
>  cannot find symbol
>   symbol:   class ForeignExceptionUtil
>   location: package org.apache.hadoop.hbase.util
> [ERROR] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[100,36]
>  cannot find symbol
>   symbol:   class ForeignExceptionUtil
>   location: package org.apache.hadoop.hbase.util
> [ERROR] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:[2144,17]
>  cannot find symbol
>   symbol:   variable ForeignExceptionUtil
>   location: class org.apache.hadoop.hbase.regionserver.HRegionServer
> [ERROR] 
> /testptch/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:[938,32]
>  cannot find symbol
>   symbol:   variable ForeignExceptionUtil
>   location: class org.apache.hadoop.hbase.master.MasterRpcServices
> {noformat}
> This bug blocks the patches which are against the hbase-protocol-shaded 
> module. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to