[
https://issues.apache.org/jira/browse/HBASE-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-4683:
-------------------------------
Attachment: D807.1.patch
mbautin requested code review of "[jira] [HBASE-4683] Always cache index and
bloom blocks".
Reviewers: jdcryans, lhofhansl, JIRA
Making sure that we always cache index and bloom blocks, as long as we have
block cache, even if the cache is disabled for the CF. Adding a unit test to
verify this using metrics. In process of doing this, I've factored out a region
creation method in HBaseTestingUtility, and cleaned up a few things in HFile
readers/writers. I have also categorized HFile v1 bloom blocks (that are
technically meta blocks) as bloom blocks in metrics.
TEST PLAN
Unit tests
REVISION DETAIL
https://reviews.facebook.net/D807
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaConfigured.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
src/test/java/org/apache/hadoop/hbase/regionserver/CreateRandomStoreFile.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/1719/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Always cache index and bloom blocks
> -----------------------------------
>
> Key: HBASE-4683
> URL: https://issues.apache.org/jira/browse/HBASE-4683
> Project: HBase
> Issue Type: New Feature
> Reporter: Lars Hofhansl
> Assignee: Mikhail Bautin
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 4683-v2.txt, 4683.txt, D807.1.patch, HBASE-4683-v3.patch
>
>
> This would add a new boolean config option: hfile.block.cache.datablocks
> Default would be true.
> Setting this to false allows HBase in a mode where only index blocks are
> cached, which is useful for analytical scenarios where a useful working set
> of the data cannot be expected to fit into the (aggregate) cache.
> This is the equivalent of setting cacheBlocks to false on all scans
> (including scans on behalf of gets).
> I would like to get a general feeling about what folks think about this.
> The change itself would be simple.
> Update (Mikhail): we probably don't need a new conf option. Instead, we will
> make index blocks cached by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
