[ 
https://issues.apache.org/jira/browse/HBASE-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674874#comment-15674874
 ] 

Yi Liang edited comment on HBASE-16708 at 11/17/16 9:37 PM:
------------------------------------------------------------

[~ndimiduk],
   As you can see in the patch, the RpcServer need go to region to get endpoint 
coprocessor implementation class name, since the coprocessor implementation 
class name is only registered in each region, master or regionserver. I doubt 
it is worthy to go that deeper to get those information, since I think the 
short service name(i.e SumServices) may be enough for us to figure out the what 
is the real coprocessor implement class(i.e  
org.myname.hbase.coprocessor.endpoint.SumEndPoint).  If just print short 
service name, RpcServer do not need to get access to region, and can make code 
more beautiful. 

And I will provide patch for only printing short service, so you can see the 
difference. 


was (Author: easyliangjob):
[~ndimiduk],
   As you can see in the patch, the RpcServer need go to region to get endpoint 
coprocessor implementation class name, since the coprocessor implementation 
class name is only registered in each region, master or regionserver. I doubt 
it is worthy to go that deeper to get those information, since I think the 
short service name(i.e SumServices) may be enough for us to figure out the what 
is the real coprocessor implement class(i.e  
org.myname.hbase.coprocessor.endpoint.SumEndPoint).  If just print short 
service name, RpcServer do not need to get access to region, and can make code 
more beautiful. 

> Expose endpoint Coprocessor name in "responseTooSlow" log messages
> ------------------------------------------------------------------
>
>                 Key: HBASE-16708
>                 URL: https://issues.apache.org/jira/browse/HBASE-16708
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Yi Liang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16708-V1.patch, HBASE-16708-V2.patch
>
>
> Operational diagnostics of a Phoenix install would be easier if we included 
> which endpoint coprocessor was being called in this responseTooSlow WARN 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to