[
https://issues.apache.org/jira/browse/HBASE-17131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681292#comment-15681292
]
Ted Yu commented on HBASE-17131:
--------------------------------
+1
The test fails without patch:
{code}
testMultiRowMutations(org.apache.hadoop.hbase.client.TestFromClientSide3) Time
elapsed: 20.962 sec <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
at
org.apache.hadoop.hbase.client.TestFromClientSide3.assertNoLocks(TestFromClientSide3.java:648)
at
org.apache.hadoop.hbase.client.TestFromClientSide3.testMultiRowMutations(TestFromClientSide3.java:642)
{code}
> Avoid livelock caused by HRegion#processRowsWithLocks
> -----------------------------------------------------
>
> Key: HBASE-17131
> URL: https://issues.apache.org/jira/browse/HBASE-17131
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0, 1.4.0, 1.3.1
> Reporter: ChiaPing Tsai
> Fix For: 2.0.0
>
> Attachments: HBASE-17131.v0.patch
>
>
> {code:title=HRegion.java|borderStyle=solid}
> try {
> // STEP 2. Acquire the row lock(s)
> acquiredRowLocks = new ArrayList<RowLock>(rowsToLock.size());
> for (byte[] row : rowsToLock) {
> // Attempt to lock all involved rows, throw if any lock times out
> // use a writer lock for mixed reads and writes
> acquiredRowLocks.add(getRowLockInternal(row, false));
> }
> // STEP 3. Region lock
> lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 :
> acquiredRowLocks.size());
> locked = true;
> boolean success = false;
> long now = EnvironmentEdgeManager.currentTime();
> try {
> {code}
> We should lock all involved rows in the second try-finally. Otherwise, we
> won’t release the previous locks if any subsequent lock times out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
