[
https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-17012:
-------------------------------------------
Attachment: HBASE-17012_3.patch
SecureWALCellCodec now works with DOS just because CellUtil APIs work with DOS.
I would say even for this the first patch way is also fine by just allowing
things to be inside it. Anyway am fine.
Added helper methods in the Dictionary interface itself and
TagcompressionContext and the WalCellCodec will use those helper methods to
write to OS from byte[] or BB. WALCellCodec will have one if/else check to see
if the cell is of type BBCell or not. I thought we need one extra util class
just for this.
> Handle Offheap cells in CompressedKvEncoder
> -------------------------------------------
>
> Key: HBASE-17012
> URL: https://issues.apache.org/jira/browse/HBASE-17012
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Affects Versions: 2.0.0
> Reporter: Anoop Sam John
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-17012_1.patch, HBASE-17012_2.patch,
> HBASE-17012_3.patch
>
>
> When we deal with off heap cells we will end up copying Cell components on
> heap
> {code}
> public void write(Cell cell) throws IOException {
> .................
> write(cell.getRowArray(), cell.getRowOffset(), cell.getRowLength(),
> compression.rowDict);
> write(cell.getFamilyArray(), cell.getFamilyOffset(),
> cell.getFamilyLength(),
> compression.familyDict);
> write(cell.getQualifierArray(), cell.getQualifierOffset(),
> cell.getQualifierLength(),
> compression.qualifierDict);
> ......
> out.write(cell.getValueArray(), cell.getValueOffset(),
> cell.getValueLength());
> ...
> {code}
> We need to avoid this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
