[
https://issues.apache.org/jira/browse/HBASE-17183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701455#comment-15701455
]
ramkrishna.s.vasudevan commented on HBASE-17183:
------------------------------------------------
{code}
Cell clonedBaseCell = ((ExtendedCell) this.cell).deepClone();
822 if (clonedBaseCell instanceof ByteBufferCell) {
823 return new TagRewriteByteBufferCell((ByteBufferCell)
clonedBaseCell, this.tags);
824 }
{code}
After deep clone() do we get cell of type BbCell? May be not needed - we can
just create TagRewriteCell only as it is deepClone will copy onheap only?
Instead of doing
{code}
overhead -= ClassSize.ARRAY;
{code}
subtraction if the tags is null - can we not add ARRAY to the overhead in the
init part and in the heap overhead do the addition if tags is not NULL? Not a
major one.
> Handle ByteBufferCell while making TagRewriteCell
> -------------------------------------------------
>
> Key: HBASE-17183
> URL: https://issues.apache.org/jira/browse/HBASE-17183
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Affects Versions: 2.0.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-17183.patch
>
>
> TagRewriteCell is the normal ExtendedCell. When it wraps a ByteBufferCell, we
> need a new TagRewriteCell type of type ByteBufferCell.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
