[
https://issues.apache.org/jira/browse/HBASE-16912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703602#comment-15703602
]
Appy commented on HBASE-16912:
------------------------------
Re-formatted the commit message.
{noformat}
+ @VisibleForTesting
+ public static HRegion createHRegion(final Configuration conf,
+ final HTableDescriptor hTableDescriptor, final HRegionInfo info,
+ final Path dir, final WAL wal, final boolean initialize) throws
IOException {
uagashe>>> can be changed to take regionStorage or masterStorage as an arg.
Args conf, dir can be removed.
{noformat}
all other createHRegion follow same method signature, so we can leave it this
way.
{noformat}
>> TestCoprocessorInterface.java
HRegionInfo info = new HRegionInfo(tableName, null, null, false);
- Path path = new Path(DIR + callingMethod);
uagashe>>> should callingMethod still be used as a root directory to give
separate area for each caller?
{noformat}
Tests are using separate table, so they are isolated.
{noformat}
>> TestRegionObserverStacking.java
HRegionInfo info = new HRegionInfo(htd.getTableName(), null, null, false);
- Path path = new Path(DIR + callingMethod);
uagashe>>> same as before.
{noformat}
There's just one test, so doesn't really matter.
{noformat}
>> TestResettingCounters.java
- }
- Region region = HBaseTestingUtility.createRegionAndWAL(hri, path, conf,
htd);
uagashe>>> should we destroyRegion to clean up after previously aborted test,
before we begin with new?
{noformat}
Only single test is there, so no cleanup needed.
> TEST: update HBaseTestingUtility to avoid direct use of filesystem / legacy
> implementation
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-16912
> URL: https://issues.apache.org/jira/browse/HBASE-16912
> Project: HBase
> Issue Type: Sub-task
> Components: Filesystem Integration
> Affects Versions: hbase-14439
> Reporter: Sean Busbey
> Assignee: Appy
> Fix For: hbase-14439
>
> Attachments: HBASE-16912.hbase-14439.001.patch,
> HBASE-16912.hbase-14439.002.patch, HBASE-16912.hbase-14439.002.review,
> fs-redo-HBTU.patch
>
>
> Update the HBaseTestingUtility to ensure it relies on MasterStorage /
> RegionStorage APIs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
