[ 
https://issues.apache.org/jira/browse/HBASE-16904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704692#comment-15704692
 ] 

Hadoop QA commented on HBASE-16904:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 28 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 57s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 
14s {color} | {color:green} hbase-14439 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 26s 
{color} | {color:green} hbase-14439 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 
7s {color} | {color:green} hbase-14439 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 
5s {color} | {color:green} hbase-14439 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s 
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 52s 
{color} | {color:red} hbase-server in hbase-14439 has 5 extant Findbugs 
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 27s 
{color} | {color:green} hbase-14439 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 11s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 11s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
28m 16s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
38s {color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s 
{color} | {color:blue} Skipped patched modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 6s 
{color} | {color:red} hbase-server generated 1 new + 5 unchanged - 0 fixed = 6 
total (was 5) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 28s 
{color} | {color:red} hbase-server generated 14 new + 11 unchanged - 0 fixed = 
25 total (was 11) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 57s 
{color} | {color:red} root generated 14 new + 30 unchanged - 0 fixed = 44 total 
(was 30) {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 2s {color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 15s {color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
30s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 105m 21s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
|  |  Dead store to conf in 
org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createRegionsOnStorage(MasterProcedureEnv,
 TableName, List)  At 
CloneSnapshotProcedure.java:org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createRegionsOnStorage(MasterProcedureEnv,
 TableName, List)  At CloneSnapshotProcedure.java:[line 348] |
| Failed junit tests | hadoop.hbase.regionserver.TestKeepDeletes |
|   | hadoop.hbase.regionserver.TestSplitTransaction |
|   | hadoop.hbase.filter.TestFilter |
|   | hadoop.hbase.fs.legacy.snapshot.TestRestoreSnapshotHelper |
|   | hadoop.hbase.master.snapshot.TestSnapshotManager |
|   | hadoop.hbase.io.encoding.TestPrefixTree |
|   | hadoop.hbase.mob.TestMobFileCache |
|   | hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow |
|   | hadoop.hbase.fs.legacy.snapshot.TestSnapshotHFileCleaner |
|   | hadoop.hbase.fs.legacy.snapshot.TestMobRestoreSnapshotHelper |
|   | hadoop.hbase.regionserver.TestDateTieredCompactionPolicy |
|   | hadoop.hbase.coprocessor.TestCoprocessorInterface |
|   | hadoop.hbase.regionserver.TestScanWithBloomError |
|   | hadoop.hbase.regionserver.TestScanner |
|   | hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan |
|   | hadoop.hbase.regionserver.TestBlocksScanned |
|   | hadoop.hbase.regionserver.TestStoreFileRefresherChore |
|   | hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormatImpl |
|   | hadoop.hbase.fs.legacy.snapshot.TestSnapshotManifest |
|   | hadoop.hbase.filter.TestMultipleColumnPrefixFilter |
|   | hadoop.hbase.filter.TestColumnPrefixFilter |
|   | hadoop.hbase.master.TestCatalogJanitor |
|   | hadoop.hbase.coprocessor.TestRegionObserverStacking |
|   | hadoop.hbase.filter.TestFilterFromRegionSide |
|   | hadoop.hbase.filter.TestInvocationRecordFilter |
|   | hadoop.hbase.regionserver.TestWideScanner |
|   | hadoop.hbase.regionserver.TestMinVersions |
|   | hadoop.hbase.regionserver.TestBulkLoad |
|   | hadoop.hbase.regionserver.TestResettingCounters |
|   | hadoop.hbase.filter.TestDependentColumnFilter |
|   | hadoop.hbase.regionserver.TestRegionMergeTransaction |
|   | hadoop.hbase.client.TestIntraRowPagination |
|   | hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange |
|   | hadoop.hbase.regionserver.TestKeepDeletes |
|   | hadoop.hbase.regionserver.TestSplitTransaction |
|   | hadoop.hbase.filter.TestFilter |
|   | hadoop.hbase.fs.legacy.snapshot.TestRestoreSnapshotHelper |
|   | hadoop.hbase.master.snapshot.TestSnapshotManager |
|   | hadoop.hbase.io.encoding.TestPrefixTree |
|   | hadoop.hbase.mob.TestMobFileCache |
|   | hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow |
|   | hadoop.hbase.fs.legacy.snapshot.TestSnapshotHFileCleaner |
|   | hadoop.hbase.fs.legacy.snapshot.TestMobRestoreSnapshotHelper |
|   | hadoop.hbase.regionserver.TestDateTieredCompactionPolicy |
|   | hadoop.hbase.coprocessor.TestCoprocessorInterface |
|   | hadoop.hbase.regionserver.TestScanWithBloomError |
|   | hadoop.hbase.regionserver.TestScanner |
|   | hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan |
|   | hadoop.hbase.regionserver.TestBlocksScanned |
|   | hadoop.hbase.regionserver.TestStoreFileRefresherChore |
|   | hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormatImpl |
|   | hadoop.hbase.fs.legacy.snapshot.TestSnapshotManifest |
|   | hadoop.hbase.filter.TestMultipleColumnPrefixFilter |
|   | hadoop.hbase.filter.TestColumnPrefixFilter |
|   | hadoop.hbase.master.TestCatalogJanitor |
|   | hadoop.hbase.coprocessor.TestRegionObserverStacking |
|   | hadoop.hbase.filter.TestFilterFromRegionSide |
|   | hadoop.hbase.filter.TestInvocationRecordFilter |
|   | hadoop.hbase.regionserver.TestWideScanner |
|   | hadoop.hbase.regionserver.TestMinVersions |
|   | hadoop.hbase.regionserver.TestBulkLoad |
|   | hadoop.hbase.regionserver.TestResettingCounters |
|   | hadoop.hbase.filter.TestDependentColumnFilter |
|   | hadoop.hbase.regionserver.TestRegionMergeTransaction |
|   | hadoop.hbase.client.TestIntraRowPagination |
|   | hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:7bda515 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12840819/HBASE-16904-hbase-14439.v3.patch
 |
| JIRA Issue | HBASE-16904 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 1d7b7f544b42 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | hbase-14439 / a36f80c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/new-findbugs-hbase-server.html
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/diff-javadoc-javadoc-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/patch-unit-hbase-server.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/patch-unit-root.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/patch-unit-hbase-server.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/artifact/patchprocess/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/testReport/ |
| modules | C: hbase-server . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/4670/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> remove directory layout / fs references from snapshots
> ------------------------------------------------------
>
>                 Key: HBASE-16904
>                 URL: https://issues.apache.org/jira/browse/HBASE-16904
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Filesystem Integration
>            Reporter: Sean Busbey
>            Assignee: Umesh Agashe
>         Attachments: HBASE-16904-hbase-14439.v1.patch, 
> HBASE-16904-hbase-14439.v2.patch, HBASE-16904-hbase-14439.v3.patch
>
>
> ensure snapshot code works through the MasterStorage / RegionStorage APIs and 
> not directly on backing filesystem.
> {code}
> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV1.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV2.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to