[
https://issues.apache.org/jira/browse/HBASE-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706160#comment-15706160
]
Jerry He commented on HBASE-17194:
----------------------------------
{noformat}
78 static final BiFunction<ServerName, ServerLoad, Boolean> predicater
79 = (name, load) -> load.getNumberOfRegions() == 0;
{noformat}
Can you rename 'predicater' to something like 'idleServerPredicator' to be
specific?
Also, could you rename the new getOnlineServersList() to something like
'getOnlineServersListWithIdlePredicator' so that it won't cause confusion like
[~stack] mentioned?
{noformat}
1096 public List<ServerName> getOnlineServersList(List<ServerName> keys,
1097 BiFunction<ServerName, ServerLoad, Boolean> predicater) {
1098 List<ServerName> names = new ArrayList<>();
1099 if (keys != null) {
1100 names.forEach(name -> {
{noformat}
Should it be 'keys.forEach'?
> Assign the new region to the idle server after splitting
> --------------------------------------------------------
>
> Key: HBASE-17194
> URL: https://issues.apache.org/jira/browse/HBASE-17194
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: ChiaPing Tsai
> Assignee: ChiaPing Tsai
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-17194.v0.patch, evaluation-v0.png
>
>
> The new regions are assigned to the random servers after splitting, but there
> always are some idle servers which don’t be assigned any regions on the new
> cluster. It is a bad start of load balance, hence we should give priority to
> the idle servers for assignment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
