[jira] [Commented] (HBASE-17211) Add more details in log when UnknownScannerException thrown in ScannerCallable

[Yu Li (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709087#comment-15709087
 ] 

Yu Li commented on HBASE-17211:
-------------------------------

Thanks for review [~jmspaggi] and [~stack], will commit with below change:
{code}
      TableName table = getTableName();
      String tableDetails = (table == null) ? "" : (" on table: " + 
table.getNameAsString());
      LOG.warn("Ignore, probably already closed. Current scan: " + 
getScan().toString()
          + tableDetails, e);
{code}

And btw, {{RegionServerCallable#prepare}} also lack of null checker of 
tableName, maybe we should also fix it? Worth another JIRA?
{code}
  public void prepare(final boolean reload) throws IOException {
    System.out.println("Preparing for table: " + tableName);
    // check table state if this is a retry
    if (reload && !tableName.equals(TableName.META_TABLE_NAME) &&
        getConnection().isTableDisabled(tableName)) {
      throw new TableNotEnabledException(tableName.getNameAsString() + " is 
disabled.");
    }
{code}

> Add more details in log when UnknownScannerException thrown in ScannerCallable
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-17211
>                 URL: https://issues.apache.org/jira/browse/HBASE-17211
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Minor
>         Attachments: HBASE-17211.patch
>
>
> Currently if we try to close an already closed scanner, we may see below 
> warning log which is useless for debugging:
> {noformat}
> 2016-06-23 01:21:21,101 WARN [main] 
> org.apache.hadoop.hbase.client.ScannerCallable: Ignore, probably already 
> closed
> org.apache.hadoop.hbase.UnknownScannerException: 
> org.apache.hadoop.hbase.UnknownScannerException: Name: 18706910, already 
> closed?
>     at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2304)
>     at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32205)
>     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2188)
>     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:102)
>     at 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:133)
>     at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:108)
> {noformat}
> and here we propose to add more details about the scan in log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)