[ 
https://issues.apache.org/jira/browse/HBASE-17205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709271#comment-15709271
 ] 

Matteo Bertozzi commented on HBASE-17205:
-----------------------------------------

looks ok to me, the only strange thing is that now RegionState is no longer an 
immutable object. maybe just avoid having that updateRitDuration() public since 
it is used only by RegionStates, and mark it as @InterfaceAudience.Private.

in any case, this fix is ok for me. with the new AM we have the actual time of 
assign and unassign operation for each region and the time of the region in 
failed open or those kind of states. so for 2.0, when the new AM is ready, we 
are probably going back to the immutable region state.  

> Add a metric for the duration of region in transition
> -----------------------------------------------------
>
>                 Key: HBASE-17205
>                 URL: https://issues.apache.org/jira/browse/HBASE-17205
>             Project: HBase
>          Issue Type: Improvement
>          Components: Region Assignment
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Minor
>         Attachments: HBASE-17205.patch
>
>
> When work for HBASE-17178, I found there are not a metric for the overall 
> duration of region in transition. When move a region form A to B, the 
> transformation of region state is PENDING_CLOSE => CLOSING => CLOSED => 
> PENDING_OPEN => OPENING => OPENED. When transform old region state to new 
> region state, it update the time stamp to current time. So we can't get the 
> overall transformation's duration of region in transition. Add a rit duration 
> to RegionState for accumulating this metric.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to