[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710817#comment-15710817
]
Phil Yang commented on HBASE-17210:
-----------------------------------
Thanks for your review.
{quote}
Should timeout be set to rowLockWaitDuration if (call.getDeadline() -
System.currentTimeMillis()) <= 0 ?
{quote}
No, it means the previous logic (eg. waiting in request queue and maybe a full
gc) spend too much time and this request has been regarded as timeout at
client, we can drop it.
{quote}
Please use EnvironmentEdgeManager.currentTime()
{quote}
It seems that after HBASE-16256 we are advised not to inject any
EnvironmentEdge so we can use System.currentTimeMillis() directly?
> Set timeout on trying rowlock according to client's RPC timeout
> ---------------------------------------------------------------
>
> Key: HBASE-17210
> URL: https://issues.apache.org/jira/browse/HBASE-17210
> Project: HBase
> Issue Type: Sub-task
> Reporter: Phil Yang
> Assignee: Phil Yang
> Attachments: HBASE-17120.v1.patch
>
>
> Now when we want to get a row lock, the timeout is fixed and default is 30s.
> But the requests from client have different RPC timeout setting. We can use
> the client's deadline to set timeout on tryLock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
