[ 
https://issues.apache.org/jira/browse/HBASE-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711798#comment-15711798
 ] 

Hudson commented on HBASE-17212:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2052 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/2052/])
HBASE-17212 Should add null checker on table name in HTable and (liyu: rev 
15fe3d3279e84d9db41b29b5f8ac7ece31490fc3)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
* (edit) 
hbase-endpoint/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java


> Should add null checker on table name in HTable constructor and 
> RegionServerCallable
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-17212
>                 URL: https://issues.apache.org/jira/browse/HBASE-17212
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17212.addendum.patch, HBASE-17212.addendum.patch, 
> HBASE-17212.patch, HBASE-17212.v2.patch
>
>
> If we run below codes:
> {code}
> Table table = connection.getTable(null);
> {code}
> we will see below exception:
> {noformat}
> java.lang.NullPointerException
>       at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:221)
>       at org.apache.hadoop.hbase.client.HTable.<init>(HTable.java:182)
>       at 
> org.apache.hadoop.hbase.client.ConnectionImplementation.getTable(ConnectionImplementation.java:298)
>       at 
> org.apache.hadoop.hbase.client.ConnectionImplementation.getTable(ConnectionImplementation.java:293)
> {noformat}
> And in this JIRA we will add a null checker and throw a more graceful 
> {{IllegalArgumentException}}
> For RegionServerCallable, we're lacking of some null checker when using table 
> name, such as in {{RegionServerCallable#prepare}}:
> {code}
>    public void prepare(final boolean reload) throws IOException {
>      // check table state if this is a retry
>     if (reload && !tableName.equals(TableName.META_TABLE_NAME) &&
>         getConnection().isTableDisabled(tableName)) {
>        throw new TableNotEnabledException(tableName.getNameAsString() + " is 
> disabled.");
>      }
> {code}
> It will throw NPE if tableName is null and invoking {{tableName.equals}}. 
> We'll add null checker in such places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to