Anoop Sam John commented on HBASE-17187:

Looks good then
Below the new lines we have 
if (e instanceof CorruptHFileException || e instanceof FileNotFoundException) {
            throw new DoNotRetryIOException(e);
We can avoid the CorruptHFileException check now.. FNFE can come from MOB area 
where the MOB file is missing..  So we need to have this check unless at the 
throwing place, we catch FNFE and rethrow as a type of DNRIOE.  Any way not 
related to ur patch.. May be u can add a TODO pls?  Also remove 
CorruptHFileException check here.  Can fix on commit pls? +1

> DoNotRetryExceptions from coprocessors should bubble up to the application
> --------------------------------------------------------------------------
>                 Key: HBASE-17187
>                 URL: https://issues.apache.org/jira/browse/HBASE-17187
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: hbase-17187_v1.patch
> In HBASE-16604, we fixed a case where scanner retries was causing the scan to 
> miss some data in case the scanner is left with a dirty state (like a 
> half-seeked KVHeap). 
> The patch introduced a minor compatibility issue, because now if a 
> coprocessor throws DNRIOE, we still retry the ClientScanner indefinitely. 
> The test {{ServerExceptionIT}} in Phoenix is failing because of this with 
> HBASE-16604. 

This message was sent by Atlassian JIRA

Reply via email to