ramkrishna.s.vasudevan updated HBASE-17191:
    Attachment: HBASE-17191_1.patch

Updated patch based on comments. Yes using CellComparator is much better so 
that we can check for all the parts of the cell.
Thanks for the review. Will commit unless objections.

> Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in 
> PBUtil#toCell(Cell cell)
> ------------------------------------------------------------------------------------------
>                 Key: HBASE-17191
>                 URL: https://issues.apache.org/jira/browse/HBASE-17191
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-17191.patch, HBASE-17191_1.patch
> Since we now have support for BBs in 
> UnsafeByteOperations#unsafeWrap(ByteBuffer) . So for the non - java clients 
> while creating the PB result we could avoid the copy to an temp array. 
> Since we have a support to write to BB in ByteOutput having a result backed 
> by Bytebuffer should be fine. 

This message was sent by Atlassian JIRA

Reply via email to