[ 
https://issues.apache.org/jira/browse/HBASE-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-17239:
-------------------------------------------
    Attachment: HBASE-17239_V1.patch

Patch that creates the src/main/patches for the changes in shaded-protobuf 
module and along with that has the corresponding changes for RpcServer.

> Add UnsafeByteOperations#wrap(ByteInput, int offset, int len) API
> -----------------------------------------------------------------
>
>                 Key: HBASE-17239
>                 URL: https://issues.apache.org/jira/browse/HBASE-17239
>             Project: HBase
>          Issue Type: Improvement
>          Components: Protobufs
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17239_V1.patch
>
>
> Instead of exposing the newInstance(ByteInput, boolean) in CIS we could just 
> add a UnsafeByteOperations#wrap(ByteInput, offset, len). And we could just 
> call that and do a #newcodedInput() over that. So internally we do return a 
> immutable version of the ByteInput only. This way we can avoid 
> CIS#newInstance(ByteInput) exposure and can keep it package private as done 
> in COS. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to