[
https://issues.apache.org/jira/browse/HBASE-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714958#comment-15714958
]
Anoop Sam John commented on HBASE-17239:
----------------------------------------
The patch has to be bit diff.
The patch has to directly patch CodedInputStream and UnsafeByteOperations.
And also to add the .patch file itself like u have here.. This is the way we
used previously.
Else patch look good
> Add UnsafeByteOperations#wrap(ByteInput, int offset, int len) API
> -----------------------------------------------------------------
>
> Key: HBASE-17239
> URL: https://issues.apache.org/jira/browse/HBASE-17239
> Project: HBase
> Issue Type: Improvement
> Components: Protobufs
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-17239_V1.patch
>
>
> Instead of exposing the newInstance(ByteInput, boolean) in CIS we could just
> add a UnsafeByteOperations#wrap(ByteInput, offset, len). And we could just
> call that and do a #newcodedInput() over that. So internally we do return a
> immutable version of the ByteInput only. This way we can avoid
> CIS#newInstance(ByteInput) exposure and can keep it package private as done
> in COS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
