[
https://issues.apache.org/jira/browse/HBASE-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15718991#comment-15718991
]
stack commented on HBASE-17221:
-------------------------------
Gave it a quick pass. Looks great. Only comment would be that there are a lot
of methods in the new RpcCall Interface. I presume we 'need' them all. I assume
you already did a weeding to make sure the set was minimal. +1 from me (and ++1
if you can purge more methods from RpcCell). Good stuff.
> Abstract out an interface for RpcServer.Call
> --------------------------------------------
>
> Key: HBASE-17221
> URL: https://issues.apache.org/jira/browse/HBASE-17221
> Project: HBase
> Issue Type: Improvement
> Reporter: Jerry He
> Assignee: Jerry He
> Fix For: 2.0.0
>
> Attachments: HBASE-17221-v2.patch, HBASE-17221.patch
>
>
> RpcServer.Call is a concrete class, but it is marked as:
> {noformat}
> @InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC,
> HBaseInterfaceAudience.PHOENIX})
> {noformat}
> Let's abstract out an interface out of it for potential consumers that want
> to pass it around.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
