[ 
https://issues.apache.org/jira/browse/HBASE-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723826#comment-15723826
 ] 

Matteo Bertozzi commented on HBASE-17250:
-----------------------------------------

[~tedyu] I don't think scan.setAttribute() is the right place for it. 
from the patch looks like the "skipCheckFamily" is specific on how we 
implemented the get() code. we are using that getScanner() in both scan() and 
get() but in get we already checked the families before calling getScanner(). 

maybe an alternative to the flag, is that in both cases we check the families 
before doing anything. since in both cases we call the coprocessors with the 
scan or get object, and in theory we want to make sure the families are 
correct. in this case we check early and getScanner() will end up without any 
check. but this means that coprocessors that are using directly 
region.getScanner() should do validation.. so maybe the skipCheckFamily flag is 
safe for compatibility and clarity

> For Get and scan in one case, checkFamily can be skipped in Region#getScanner
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-17250
>                 URL: https://issues.apache.org/jira/browse/HBASE-17250
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>         Attachments: HBASE-17250-master-001.patch
>
>
> For get(), checkFamily is done in prepareGet(), so checkFamily can be skipped 
> in Region#getScanner(). For scan(), if there is no Family configured in scan, 
> the families are from table descriptor, so checkFamily in 
> Region#getScanner(). can be skipped in this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to