[
https://issues.apache.org/jira/browse/HBASE-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735800#comment-15735800
]
Ted Yu commented on HBASE-16336:
--------------------------------
Please name your next patch with proper JIRA number.
{code}
+ LOG.error("start replicationZKLockCleanerChore failed", e);
{code}
There is no Lock in ReplicationZKNodeCleanerChore. Correct the log message
above.
For ReplicationZKNodeCleaner, add javadoc and audience annotation.
{code}
+ public ReplicationZKNodeCleaner(Configuration conf, ZooKeeperWatcher zkw,
Abortable abortable) throws IOException {
{code}
Wrap long line.
{code}
+ } catch (KeeperException ke) {
+ throw new IOException(ke);
{code}
Add some message as is done in getUnDeletedHFileRefsQueues()
{code}
+ LOG.info("remove replication queue, replicator: " + replicator + ",
queueId: " + queueId);
{code}
remove -> removed
{code}
+public class ReplicationZKNodeCleanerChore extends ScheduledChore {
{code}
Add javadoc and audience annotation.
> Removing peers seem to be leaving spare queues
> ----------------------------------------------
>
> Key: HBASE-16336
> URL: https://issues.apache.org/jira/browse/HBASE-16336
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
> Reporter: Joseph
> Assignee: Guanghao Zhang
> Attachments: HBASE-15867-v1.patch, HBASE-15867-v2.patch
>
>
> I have been running IntegrationTestReplication repeatedly with the backported
> Replication Table changes. Every other iteration of the test fails with, but
> these queues should have been deleted when we removed the peers. I believe
> this may be related to HBASE-16096, HBASE-16208, or HBASE-16081.
> 16/08/02 08:36:07 ERROR util.AbstractHBaseTool: Error running command-line
> tool
> org.apache.hadoop.hbase.replication.ReplicationException: undeleted queue for
> peerId: TestPeer, replicator:
> hbase4124.ash2.facebook.com,16020,1470150251042, queueId: TestPeer
> at
> org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.checkQueuesDeleted(ReplicationPeersZKImpl.java:544)
> at
> org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.addPeer(ReplicationPeersZKImpl.java:127)
> at
> org.apache.hadoop.hbase.client.replication.ReplicationAdmin.addPeer(ReplicationAdmin.java:200)
> at
> org.apache.hadoop.hbase.test.IntegrationTestReplication$VerifyReplicationLoop.setupTablesAndReplication(IntegrationTestReplication.java:239)
> at
> org.apache.hadoop.hbase.test.IntegrationTestReplication$VerifyReplicationLoop.run(IntegrationTestReplication.java:325)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.test.IntegrationTestReplication.runTestFromCommandLine(IntegrationTestReplication.java:418)
> at
> org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:134)
> at
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:112)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.test.IntegrationTestReplication.main(IntegrationTestReplication.java:424)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
