[
https://issues.apache.org/jira/browse/HBASE-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169912#comment-13169912
]
Phabricator commented on HBASE-5021:
------------------------------------
mbautin has commented on the revision "[jira] [HBase-5021] Enforce upper bound
on timestamp".
Looks good! A couple of comments inline (based on our offline discussion).
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:458 FOREVER
is Integer.MAX_VALUE. Since we are dealing with timestamps and here and not
TTLs, should the default for this particular conf option be Long.MAX_VALUE
instead?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:404 This
should probably be Long.MAX_VALUE.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:2232
Long.MAX_VALUE
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:2230-2231 now
-> nowMs or nowMillis?
REVISION DETAIL
https://reviews.facebook.net/D849
> Enforce upper bound on timestamp
> --------------------------------
>
> Key: HBASE-5021
> URL: https://issues.apache.org/jira/browse/HBASE-5021
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Priority: Critical
> Fix For: 0.94.0
>
> Attachments: D849.1.patch
>
>
> We have been getting hit with performance problems on our time-series
> database due to invalid timestamps being inserted by the timestamp. We are
> working on adding proper checks to app server, but production performance
> could be severely impacted with significant recovery time if something slips
> past. Since timestamps are considered a fundamental part of the HBase schema
> & multiple optimizations use timestamp information, we should allow the
> option to sanity check the upper bound on the server-side in HBase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
