[
https://issues.apache.org/jira/browse/HBASE-17294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742514#comment-15742514
]
Ted Yu edited comment on HBASE-17294 at 12/12/16 5:33 PM:
----------------------------------------------------------
Add comment of short description for each type in the enum:
{code}
+ public enum MemoryCompaction {
+ NONE,
+ BASIC,
+ EAGER
{code}
{code}
- return DEFAULT_IN_MEMORY_COMPACTION;
+ return null;
{code}
Should NONE be returned above ?
{code}
+import static org.apache.hadoop.hbase.HColumnDescriptor.*;
+import static org.apache.hadoop.hbase.HColumnDescriptor.MemoryCompaction.*;
{code}
Please try not to use wildcard in import.
was (Author: [email protected]):
Add comment of short description for each type in the enum:
{code}
+ public enum MemoryCompaction {
+ NONE,
+ BASIC,
+ EAGER
{code}
{code}
- return DEFAULT_IN_MEMORY_COMPACTION;
+ return null;
{code}
Should NONE be returned above ?
{code}
+import static org.apache.hadoop.hbase.HColumnDescriptor.*;
+import static org.apache.hadoop.hbase.HColumnDescriptor.MemoryCompaction.*;
{code}
Please try not to use wildcard in import.
Please check failed tests.
> External Configuration for Memory Compaction
> ---------------------------------------------
>
> Key: HBASE-17294
> URL: https://issues.apache.org/jira/browse/HBASE-17294
> Project: HBase
> Issue Type: Sub-task
> Reporter: Eshcar Hillel
> Assignee: Eshcar Hillel
> Attachments: HBASE-17294-V01.patch, HBASE-17294-V02.patch
>
>
> We would like to have a single external knob to control memstore compaction.
> Possible memstore compaction policies are none, basic, and eager.
> This sub-task allows to set this property at the column family level at table
> creation time:
> {code}
> create ‘<tablename>’,
> {NAME => ‘<cfname>’,
> IN_MEMORY_COMPACTION => ‘<NONE|BASIC|EAGER>’}
> {code}
> or to set this at the global configuration level by setting the property in
> hbase-site.xml, with BASIC being the default value:
> {code}
> <property>
> <name>hbase.hregion.compacting.memstore.type</name>
> <value><NONE|BASIC|EAGER></value>
> </property>
> {code}
> The values used in this property can change as memstore compaction policies
> evolve over time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
