[
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745599#comment-15745599
]
stack commented on HBASE-17081:
-------------------------------
[~anastas]
Are we going to have an if/else per flush policy
if (compositeSnapshot) {
Can you presize the Array?
82 LinkedList<ImmutableSegment> result = new
LinkedList<ImmutableSegment>();
As said before, this is expensive...
private final TimeRangeTracker timeRangeTracker;
Its needed?
Skimmed the patch. LGTM. +1. Would wait on [~anoop.hbase] blessing. What
follow-ons do we have?
> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
> Key: HBASE-17081
> URL: https://issues.apache.org/jira/browse/HBASE-17081
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anastasia Braginsky
> Assignee: Anastasia Braginsky
> Attachments: HBASE-17081-V01.patch, HBASE-17081-V02.patch,
> HBASE-17081-V03.patch, HBASE-17081-V04.patch, HBASE-17081-V05.patch,
> HBASE-17081-V06.patch, HBASE-17081-V06.patch,
> HBaseMeetupDecember2016-V02.pptx, Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another
> part is divided between immutable segments in the compacting pipeline. Upon
> flush-to-disk request we want to flush all of it to disk, in contrast to
> flushing only tail of the compacting pipeline.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
