[
https://issues.apache.org/jira/browse/HBASE-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747818#comment-15747818
]
Anastasia Braginsky commented on HBASE-17291:
---------------------------------------------
[~ram_krish], please add your patch to the review board. Can you also please
elaborate about "all the test cases in HBASE-17081 passes"? Currently in all
tests in HBASE-17081 are OK, is it that they do not pass with this patch?
> Remove ImmutableSegment#getKeyValueScanner
> ------------------------------------------
>
> Key: HBASE-17291
> URL: https://issues.apache.org/jira/browse/HBASE-17291
> Project: HBase
> Issue Type: Improvement
> Components: Scanners
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-17291.patch, HBASE-17291_1.patch
>
>
> This is based on a discussion over [~anastas]'s patch. The MemstoreSnapshot
> uses a KeyValueScanner which actually seems redundant considering we already
> have a SegmentScanner. The idea is that the snapshot scanner should be a
> simple iterator type of scanner but it lacks the capability to do the
> reference counting on that segment that is now used in snapshot. With
> snapshot having mulitple segments in the latest impl it is better we hold on
> to the segment by doing ref counting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
