[ 
https://issues.apache.org/jira/browse/HBASE-17292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749244#comment-15749244
 ] 

Ted Yu commented on HBASE-17292:
--------------------------------

bq. Hooks in RegionObserver usually comes in pairs: pre- and post-
Just want to confirm: you're suggesting adding postCommitStoreFile() in 
HStore#bulkLoadHFile() after fs.commitStoreFile() call:
{code}
  public Path bulkLoadHFile(String srcPathStr, Path dstPath) throws IOException 
{
    Path srcPath = new Path(srcPathStr);
    fs.commitStoreFile(srcPath, dstPath);
{code}

bq. Who else is going to use this hook

Once this hook is added, bulk load support for replication would be able to use 
it as well.

> Add observer notification before bulk loaded hfile is moved to region 
> directory
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-17292
>                 URL: https://issues.apache.org/jira/browse/HBASE-17292
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 17292.v1.txt
>
>
> Currently the postBulkLoadHFile() hook notifies the locations of bulk loaded 
> hfiles.
> However, if bulk load fails after hfile is moved to region directory but 
> before postBulkLoadHFile() hook is called, there is no way for pluggable 
> components (replication, backup / restore) to know which hfile(s) have been 
> moved to region directory.
> This issue adds a preCommitStoreFile() hook which notifies path of to be 
> committed hfile before bulk loaded hfile is moved to region directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to