[
https://issues.apache.org/jira/browse/HBASE-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170330#comment-13170330
]
stack commented on HBASE-5027:
------------------------------
First, counting connections addition is excellent.
Should we add an lsof dump when your checks notice leak? Could run it in
hadoop qa only?
Is this a regression:
{code}
public static void checkHBaseAvailable(Configuration conf)
throws MasterNotRunningException, ZooKeeperConnectionException {
- Configuration copyOfConf = HBaseConfiguration.create(conf);
- copyOfConf.setInt("hbase.client.retries.number", 1);
- HBaseAdmin admin = new HBaseAdmin(copyOfConf);
+ HBaseAdmin admin = new HBaseAdmin(conf);
try {
{code}
You've dropped the retry once config?
I like your change to the testCheckHBaseAvailableClosesConnection test.
> HConnection.create(final Connection conf) does not clone, it creates a new
> Configuration reading *.xmls and then does a merge.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5027
> URL: https://issues.apache.org/jira/browse/HBASE-5027
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: stack
> Assignee: nkeywal
> Fix For: 0.94.0
>
> Attachments: 5027.patch
>
>
> Its more expensive that it should be; its causing TestAdmin to fail after
> HBASE-4417 went in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
