[
https://issues.apache.org/jira/browse/HBASE-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755588#comment-15755588
]
Ted Yu commented on HBASE-17314:
--------------------------------
{code}
936 public static final int REPLICATION_SOURCE_TOTAL_BUFFER_DFAULT = 256
* 1024 * 1024;
{code}
How is the above determined ?
{code}
154 private AtomicInteger bufferUsed;
{code}
Make the variable name more indicative of its purpose. How about naming it
totalBufferUsed ?
{code}
209 this.quotaPermits =
conf.getInt(HConstants.REPLICATION_SOURCE_TOTAL_BUFFER_KEY,
{code}
Align variable name with its purpose.
{code}
130 private AtomicInteger totalBufferUsed = new AtomicInteger();
{code}
Where is the above variable incremented ?
Please fix failing tests.
> Limit total buffered size for all replication sources
> -----------------------------------------------------
>
> Key: HBASE-17314
> URL: https://issues.apache.org/jira/browse/HBASE-17314
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Reporter: Phil Yang
> Assignee: Phil Yang
> Attachments: HBASE-17314.v01.patch, HBASE-17314.v02.patch,
> HBASE-17314.v03.patch
>
>
> If we have many peers or some servers have many recovered queues, we will
> hold many entries in memory which will increase the pressure of GC, even
> maybe OOM because we will read entries for 64MB to buffer in default for one
> source.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
