[
https://issues.apache.org/jira/browse/HBASE-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755935#comment-15755935
]
Ted Yu commented on HBASE-17280:
--------------------------------
{code}
+ return stub.enableCleaner(controller, request);
{code}
Currently we have:
{code}
public boolean setBalancerRunning(final boolean on, final boolean synchronous)
{code}
How about naming the new method setCleanerRunning ?
{code}
+ boolean isCleanerEnabled() {
+ if (hfileCleaner != null && logCleaner != null) {
+ return hfileCleaner.getEnabled() && logCleaner.getEnabled();
{code}
Should hfile and log cleaners get their own flag ?
{code}
+ public RunCleanerResponse runCleaner(RpcController c, RunCleanerRequest req)
...
+ Boolean result = master.getHFileCleaner().runCleaner()
+ && master.getLogCleaner().runCleaner();
{code}
No need to check whether the cleaners are enabled ?
{code}
+ } else {
+ LOG.warn("Cleaner disabled! Not cleaning.");
{code}
Would the above flood log file ?
> Add mechanism to control hbase cleaner behavior
> -----------------------------------------------
>
> Key: HBASE-17280
> URL: https://issues.apache.org/jira/browse/HBASE-17280
> Project: HBase
> Issue Type: Improvement
> Components: Client, hbase, shell
> Affects Versions: 2.0.0, 1.2.0
> Reporter: Ajay Jadhav
> Priority: Minor
> Fix For: 2.0.0, 1.2.0
>
> Attachments: HBASE-17280.branch-1.2.patch,
> HBASE-17280.branch-2.0.patch
>
>
> Cleaner is used to get rid of archived HFiles and old WALs in HBase.
> In the case of heavy workload, cleaner can affect query performance by
> creating a lot of connections to perform costly reads/ writes against
> underlying filesystem.
> This patch allows the user to control HBase cleaner behavior by providing
> shell commands to enable/ disable and manually run it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
