[
https://issues.apache.org/jira/browse/HBASE-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15757119#comment-15757119
]
Jianwei Cui commented on HBASE-17330:
-------------------------------------
Thanks for the review [~tedyu]. As mentioned above, it seems not need to
consider modify time of tmp directory in {{SnapshotFileCache#refreshCache}}?
Then, the {{hasChange}} could be easily judged by
{{fs.getFileStatus(snapshotDir).getModificationTime() > lastModifiedTime}}.
> SnapshotFileCache will always refresh the file cache
> ----------------------------------------------------
>
> Key: HBASE-17330
> URL: https://issues.apache.org/jira/browse/HBASE-17330
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.0.0, 1.3.1, 0.98.23
> Reporter: Jianwei Cui
> Priority: Minor
> Attachments: HBASE-17330-v1.patch
>
>
> In {{SnapshotFileCache#refreshCache}}, the {{hasChanges}} will be judged as:
> {code}
> try {
> FileStatus dirStatus = fs.getFileStatus(snapshotDir);
> lastTimestamp = dirStatus.getModificationTime();
> hasChanges |= (lastTimestamp >= lastModifiedTime); // >= will make
> hasChanges always be true
> {code}
> The {{(lastTimestamp >= lastModifiedTime)}} will make {{hasChanges}} always
> be true because {{lastTimestamp}} will be updated as:
> {code}
> this.lastModifiedTime = lastTimestamp;
> {code}
> So, SnapshotFileCache will always refresh the file cache.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
