[ 
https://issues.apache.org/jira/browse/HBASE-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15757190#comment-15757190
 ] 

Ted Yu commented on HBASE-17331:
--------------------------------

{code}
149         } catch (InterruptedException e) {
150           throw new IOException("Thread aborted", e);
{code}
Please throw InterruptedIOException

> Avoid busy waiting in ThrottledInputStream
> ------------------------------------------
>
>                 Key: HBASE-17331
>                 URL: https://issues.apache.org/jira/browse/HBASE-17331
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17331.v0.patch, HBASE-17331.v1.patch
>
>
> {code:title=ThrottledInputStream.java|borderStyle=solid}
> // We can calculate the precise sleep time instead of busy waiting
>   private void throttle() throws IOException {
>     while (getBytesPerSec() > maxBytesPerSec) {
>       try {
>         Thread.sleep(SLEEP_DURATION_MS);
>         totalSleepTime += SLEEP_DURATION_MS;
>       } catch (InterruptedException e) {
>         throw new IOException("Thread aborted", e);
>       }
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to