[
https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15760303#comment-15760303
]
Anoop Sam John commented on HBASE-17333:
----------------------------------------
{code}
if (inMemoryCompaction != null) {
246 inMemoryCompaction = HColumnDescriptor.MemoryCompaction
247
.valueOf(conf.get(CompactingMemStore.COMPACTING_MEMSTORE_TYPE_KEY,
248 CompactingMemStore.COMPACTING_MEMSTORE_TYPE_DEFAULT));
{code}
When a type is specified at HCD level, that has to be honored whereas this
patch try to change it to global conf level
The issue is this. When read from conf, the default to be used as
HColumnDescriptor.MemoryCompaction.NONE
That single change should fix it.
Only HBASE-17323 this is the test issue? Or any thing else?
Can change some comments and change the title and description of the jira. Or
may be after this commit, that can be closed and we can open a new one to
track, why the test fail with CompactingMS feature
> HBASE-17294 always ensures CompactingMemstore is default
> --------------------------------------------------------
>
> Key: HBASE-17333
> URL: https://issues.apache.org/jira/browse/HBASE-17333
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-17333.patch
>
>
> Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am
> not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA
> is to discuss and revert back to default memstore only if the family is not
> configured for in memory flush/compaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
