[
https://issues.apache.org/jira/browse/HBASE-17288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761171#comment-15761171
]
Anoop Sam John commented on HBASE-17288:
----------------------------------------
currentInResultRowSizeInByte - Call it currentRowSize
{code}
if (rsService != null && scanInfo.isParallelSeekEnabled()) {
188 hugeCellWarningSizeInByte = rsService.getConfiguration().getInt(
189 HUGE_CELL_SIZE_IN_BYTE_WARN_NAME,
HUGE_CELL_SIZE_IN_BYTE_WARN_VALUE);
{code}
You init these new vars when parallel seek enabled. I believe simple mistake
it is and not intended by you
{code}
LOG.warn("adding a huge row's cell into result list, added row size: "
902 + StringUtils.humanSize(currentInResultRowSizeInByte) + ",
cell: " + cell
903 + ", from table " +
store.getRegionInfo().getTable().getNameAsString());
{code}
No need to include the Cell as such in this log. Any way 1st cell which causes
the break in the row size check, will make into the log. We can mention the row
size and table name.
And one more..THis size is not exactly the row's size. There might be still
rows after that.. Better we can do the row size check and the end after
considering all cells so that we can get exactly the size of the row? Or is
that not possible as per loop here? I did not check. If possible, we can avoid
logHugeRow state also.
Else looks ok
> Add warn log for huge Cell and huge row
> ---------------------------------------
>
> Key: HBASE-17288
> URL: https://issues.apache.org/jira/browse/HBASE-17288
> Project: HBase
> Issue Type: Improvement
> Components: scan
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Priority: Minor
> Attachments: HBASE-17288-v1.patch, HBASE-17288-v2.patch,
> HBASE-17288.patch
>
>
> Some log examples from our production cluster.
> {code}
> 2016-12-10,17:08:11,478 WARN
> org.apache.hadoop.hbase.regionserver.StoreScanner: adding a HUGE KV into
> result list, kv size:1253360,
> kv:105671140000001-1-c/R:r1/1481360887152/Put/vlen=1253245/ts=923099, from
> table XXXXX
> 2016-12-10,17:08:16,724 WARN
> org.apache.hadoop.hbase.regionserver.StoreScanner: adding a HUGE KV into
> result list, kv size:1048680,
> kv:0220459/I:i_0/1481360889551/Put/vlen=1048576/ts=13642, from table XXXXXX
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
