[
https://issues.apache.org/jira/browse/HBASE-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171117#comment-13171117
]
Zhihong Yu commented on HBASE-5053:
-----------------------------------
I see some empty lines added by the patch. They should be removed.
For the case of missing connection, I think the log should be at ERROR level.
Also, toString() call isn't needed in the message body:
{code}
+ LOG.warn("Connection not found in the list, can't delete it "+
+ "(connection key="+connectionKey.toString()+")");
{code}
> HCM Tests leaks connections
> ---------------------------
>
> Key: HBASE-5053
> URL: https://issues.apache.org/jira/browse/HBASE-5053
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5053.patch
>
>
> There are simple leaks and one more complex.
> The complex one comes from the fact fact
> HConnectionManager.HConnectionImplementation keeps a *reference* to the
> configuration used for the creation. So if this configuration is updated
> later, the HConnectionKey created initially will differ from the current one.
> As a consequence, the close() will not find the connection anymore in the
> list, and the connection won't be deleted.
> I added a warning when a close does not find the connection in the list; but
> I wonder if we should not copy the HConnectionKey instead of keeping a
> reference.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
