[
https://issues.apache.org/jira/browse/HBASE-17393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793423#comment-15793423
]
huaxiang sun commented on HBASE-17393:
--------------------------------------
Reading code bit more, actually it assumes that at the Region Server side, the
embedded TimeRange is [min, max]. [min, max) is only for the client side. Given
this assumption, the logic TimeRange#includesTimeRange is correct, though this
makes code reading hard.
> Logic in TimeRange#includesTimeRange is incorrect
> -------------------------------------------------
>
> Key: HBASE-17393
> URL: https://issues.apache.org/jira/browse/HBASE-17393
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: huaxiang sun
> Assignee: huaxiang sun
> Priority: Minor
>
> In the code,
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java#L181
>
> return getMin() < tr.getMax() && getMax() >= tr.getMin();
> Given that TimeRange is defined as [minStamp,maxStamp),
> Assume that TimeRange(4, 5). includesTimeRange(TimeRange(5,6)).
> So it will be (4 < 6) && (5 >=5), the result is true.
> Same for TimeRangeTracker#includesTimeRange
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
