[
https://issues.apache.org/jira/browse/HBASE-17337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804452#comment-15804452
]
Ashish Singhi commented on HBASE-17337:
---------------------------------------
Add javadoc and InterfaceAudience to ReplicationPeerDescription class.
{code}
111 for (String peerId : peerIds) {
112 if (pattern == null || (pattern != null &&
pattern.matcher(peerId).matches())) {
113 peers.add(new ReplicationPeerDescription(peerId,
replicationPeers
114 .getStatusOfPeerFromBackingStore(peerId), replicationPeers
115 .getReplicationPeerConfig(peerId)));
116 }
117 }
{code}
If pattern is not null and once the pattern matches the peer id then we can
break out of the for loop.
If user passes a pattern which doesn't match any existing peerIds, I think we
should throw ReplicationPeerNotFoundException/IllegalArgumentException for it.
> list replication peers request should be routed through master
> --------------------------------------------------------------
>
> Key: HBASE-17337
> URL: https://issues.apache.org/jira/browse/HBASE-17337
> Project: HBase
> Issue Type: Sub-task
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17337-v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
