[
https://issues.apache.org/jira/browse/HBASE-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804586#comment-15804586
]
Ted Yu commented on HBASE-17431:
--------------------------------
+1 on v2
> Incorrect precheck condition in RoundRobinPool#get()
> ----------------------------------------------------
>
> Key: HBASE-17431
> URL: https://issues.apache.org/jira/browse/HBASE-17431
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Jan Hentschel
> Priority: Minor
> Attachments: HBASE-17431.master.001.patch,
> HBASE-17431.master.002.patch
>
>
> Here is related code:
> {code}
> public R get() {
> if (super.size() < maxSize) {
> return null;
> }
> nextResource %= super.size();
> {code}
> Since super.size() is involved in modulo operation after the check, it seems
> the check should compare against 0 instead of maxSize.
> Looks like a copy-paste error from put() method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
