[ 
https://issues.apache.org/jira/browse/HBASE-17437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806867#comment-15806867
 ] 

stack commented on HBASE-17437:
-------------------------------

[~yangyishan0901m] Thank you for your submission.

WAL dir gets same pegging as the root dir. Interesting. Could be helpful in 
cases other than S3+EBS/EFS. We are working on redo of the fs layout but I'd 
think we could take this change in the meantime.

How amenable are you to feedback on the patch? Is it deployed by you lot 
already? If so, I'd imagine big changes would be tough?

Here is some quick feedback. More detail to follow.

Patch looks good. 

You use 'hlog' when you talk of the WAL dir and attributes. Would be better if 
you s/hlog/wal/g and s/LOG/WAL/g. e.g. s/getLogRootDir/getWALDir/g This is a 
nit.

Thanks.







> Support specifying a WAL directory outside of the root directory
> ----------------------------------------------------------------
>
>                 Key: HBASE-17437
>                 URL: https://issues.apache.org/jira/browse/HBASE-17437
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.4
>            Reporter: Yishan Yang
>              Labels: patch
>             Fix For: 2.0.0, 1.2.5
>
>         Attachments: hbase-17437-branch-1.2.patch, hbase-17437-master.patch
>
>
> Currently, the WAL and the StoreFiles need to be on the same FileSystem. Some 
> FileSystems (such as Amazon S3) don’t support append or consistent writes. 
> These two properties are imperative for the WAL in order to avoid loss of 
> writes. However, StoreFiles don’t necessarily need the same consistency 
> guarantees (since writes are cached locally and if writes fail, they can 
> always be replayed from the WAL).
>  
> This JIRA aims to allow users to configure a log directory (for WALs) that is 
> outside of the root directory or even in a different FileSystem. The default 
> value will still put the log directory under the root directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to