[ 
https://issues.apache.org/jira/browse/HBASE-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811518#comment-15811518
 ] 

Hudson commented on HBASE-17291:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2286 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/2286/])
HBASE-17291 Remove ImmutableSegment#getKeyValueScanner (Ram) (ramkrishna: rev 
f65a439f0188c0811c2ca07b5d830498809a13ab)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSnapshot.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellArrayMapMemStore.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java
* (add) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SnapshotScanner.java


> Remove ImmutableSegment#getKeyValueScanner
> ------------------------------------------
>
>                 Key: HBASE-17291
>                 URL: https://issues.apache.org/jira/browse/HBASE-17291
>             Project: HBase
>          Issue Type: Improvement
>          Components: Scanners
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17291.patch, HBASE-17291_1.patch, 
> HBASE-17291_2.patch, HBASE-17291_3.patch
>
>
> This is based on a discussion over [~anastas]'s patch. The MemstoreSnapshot 
> uses a KeyValueScanner which actually seems redundant considering we already 
> have a SegmentScanner. The idea is that the snapshot scanner should be a 
> simple iterator type of scanner but it lacks the capability to do the 
> reference counting on that segment that is now used in snapshot. With 
> snapshot having mulitple segments in the latest impl it is better we hold on 
> to the segment by doing ref counting. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to