[
https://issues.apache.org/jira/browse/HBASE-17470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826744#comment-15826744
]
Stephen Yuan Jiang commented on HBASE-17470:
--------------------------------------------
[~stack], the dispatchMergingRegions RPC exists in 1.x branches too. It was
used to call DispatchMergingRegionHandler in master and then master send
MergeRegionsRequest call to RS to complete merge in RS-side.
In master branch, the DispatchMergingRegionHandler was replaced by
DispatchMergingRegionsProcedure. Now MergeTableRegionsProcedure moves all the
logic to master and we no longer need those RPCs.
The incompatible changes are about removing these RPCs and remove Merge and
HMerge tools in master branch.
For the testing, since only internal implementation is changed, any existing
tests that calls Admin.mergeRegions and Admin.mergeRegionsAsync would still be
there to cover this feature (and also MergeTableRegionsProcedure has UT to
cover merge in component level). By the way, before removing these RS-side of
code, HBASE-16119 already made all merge code to call the new
MergeTableRegionsProcedure (aka, the RS-side of logic already obsolete with the
HBASE-16119 commit; I did miss one in TestAdmin1, which I fixed in this patch,
probably the only real change in the patch).
> Remove merge region code from region server
> -------------------------------------------
>
> Key: HBASE-17470
> URL: https://issues.apache.org/jira/browse/HBASE-17470
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Affects Versions: 2.0.0
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Fix For: 2.0.0
>
> Attachments: HBASE-17470.v1-master.patch,
> HBASE-17470.v2-master.patch, HBASE-17470.v3-master.patch
>
>
> HBASE-16119 moves the merge region to the master-side. There is no need to
> keep region_server-side merge region code to remove logic duplication.
> util.Merge and HMerge tools depends on RS-side merge region logic. However,
> now we can merge regions using shell command. It is dangerous to do offline
> merge. For 2.0, it is a good time to remove those out-of-date tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
