[
https://issues.apache.org/jira/browse/HBASE-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829410#comment-15829410
]
ChiaPing Tsai commented on HBASE-17488:
---------------------------------------
hi [~stack]
bq. What sort of benefit do you expect
prevent creating unused objects in the WALEdit's construction.
# If the cp#preBatchMutate returns true, the WALEdit is useless. So we should
create the WALEdit after step 2.
# The cells came from cp should be counted because they are added into the
WALEdit . The use case is the local index of phoenix
# If the mutation contains the SKIP_WAL property, its cells aren't added into
the WALEdit. So these cells shouldn't be counted.
> WALEdit should be lazily instantiated
> -------------------------------------
>
> Key: HBASE-17488
> URL: https://issues.apache.org/jira/browse/HBASE-17488
> Project: HBase
> Issue Type: Improvement
> Reporter: ChiaPing Tsai
> Assignee: ChiaPing Tsai
> Priority: Trivial
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-17488.branch-1.v0.patch
>
>
> Some trivial improvement.
> # create the WALEdit on step 3 instead of step 2
> # count the cells from coprocessor
> # don’t count the mutations which contain the Durability.SKIP_WAL property
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
