[ 
https://issues.apache.org/jira/browse/HBASE-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830393#comment-15830393
 ] 

stack commented on HBASE-16812:
-------------------------------

[~jingcheng.du] I removed this as a blocker on HBASE-16786 given HBASE-16786 
moved all locks to be procedure based in HMobStore. Let me know if you think 
this a prob. Would be cool getting this one in regardless. Thanks boss.

> Fix mob locks and correctly override HMobStore.compact() 
> ---------------------------------------------------------
>
>                 Key: HBASE-16812
>                 URL: https://issues.apache.org/jira/browse/HBASE-16812
>             Project: HBase
>          Issue Type: Task
>            Reporter: Appy
>            Assignee: Jingcheng Du
>            Priority: Minor
>         Attachments: HBASE-16812.master.001.patch
>
>
> compact(CompactionContext compaction, CompactionThroughputController 
> throughputController) is [deprecated in 1.2.0 
> release|https://github.com/apache/hbase/blob/rel/1.2.0/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java#L222].
> Store.java is also marked limited private.
> Context: I was cleaning up zk table lock which is also used in that method's 
> [override|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java#L460]
>  in HMobStore.
> This method isn't being called from anywhere except CompactionTool (which 
> creates HStore object, not HMobStore object).
> [[email protected]] Can you PTAL and help me understand what's going on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to