[
https://issues.apache.org/jira/browse/HBASE-17489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832976#comment-15832976
]
Duo Zhang commented on HBASE-17489:
-----------------------------------
{quote}
The patch makes valiant effort and trying to clean up
{quote}
Before the code becomes completely unmaintable...
And I think the logic in RSRpcService is much easier to understand than
ClientScanner. The problem of RSRpcService.scan is that, the method is too
long... I can not even find the paired brace which makes the code really hard
to read... So I split the code into several sub methods.
Thanks.
> ClientScanner may send a next request to a RegionScanner which has been
> exhausted
> ---------------------------------------------------------------------------------
>
> Key: HBASE-17489
> URL: https://issues.apache.org/jira/browse/HBASE-17489
> Project: HBase
> Issue Type: Bug
> Components: Client, scan
> Affects Versions: 2.0.0, 1.3.0, 1.4.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Critical
> Fix For: 2.0.0, 1.4.0, 1.3.1
>
> Attachments: HBASE-17489.patch, HBASE-17489-v1.patch,
> HBASE-17489-v2.patch, HBASE-17489-v3.patch, HBASE-17489-v4.patch,
> HBASE-17489-v4.patch, HBASE-17489-v5.patch
>
>
> Found it when implementing HBASE-17045. Seems the final result of the scan is
> correct but no doubt the logic is broken. We need to fix it to stop things
> get worse in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
