[
https://issues.apache.org/jira/browse/HBASE-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833308#comment-15833308
]
stack commented on HBASE-17491:
-------------------------------
+1 on v7.
On commit, change the class comment so it says since 2.0.0 rather than since
'...after HBASE-17471....'
And fix this comment if it is not right (it doesn't seem right)....
{code}
Please change to use {@link TableBuilder} to get an old style non-thread-safe
{@link Table} instance.
{code}
It seems wrong because I can 'break' thread-safeness on any HTable instance by
using setters... even if I use TableBuilder?
Nit: on commit add 'since 2.0.0' to these javadoc...
* @deprecated use {@link TableBuilder#setOperationTimeout} instead
... but not important.
+1.
> Remove all setters from HTable interface and introduce a TableBuilder to
> build Table instance
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-17491
> URL: https://issues.apache.org/jira/browse/HBASE-17491
> Project: HBase
> Issue Type: Sub-task
> Reporter: Yu Li
> Assignee: Yu Li
> Attachments: HBASE-17491.patch, HBASE-17491.v2.patch,
> HBASE-17491.v3.patch, HBASE-17491.v4.patch, HBASE-17491.v5.patch,
> HBASE-17491.v6.patch, HBASE-17491.v7.patch
>
>
> As titled, we will remove all setters in HTable for master branch and
> deprecate them for branch-1 to make HTable thread-safe. And a new
> {{TableBuilder}} interface will be introduced to build Table instance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
