[
https://issues.apache.org/jira/browse/HBASE-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834012#comment-15834012
]
Jingcheng Du commented on HBASE-16981:
--------------------------------------
Thanks [~huaxiang].
Have you updated the patch to address Ted's and Esteban's comments in RB?
{code}
public void updateLatestDate(final String latestDate) {
if ((this.latestDate == null) || (this.latestDate.compareTo(latestDate) <
0)) {
this.latestDate = latestDate;
}
}
{code}
The latestDate has been initialized as empty string. Do we need to check the
null?
Overall I am +1 on the patch if the comments from others are addressed.
Hi [~anoop.hbase], do you want to take a look at the patch? Thanks.
> Expand Mob Compaction Partition policy from daily to weekly, monthly and
> beyond
> -------------------------------------------------------------------------------
>
> Key: HBASE-16981
> URL: https://issues.apache.org/jira/browse/HBASE-16981
> Project: HBase
> Issue Type: New Feature
> Components: mob
> Affects Versions: 2.0.0
> Reporter: huaxiang sun
> Assignee: huaxiang sun
> Attachments: HBASE-16981.master.001.patch,
> HBASE-16981.master.002.patch, HBASE-16981.master.003.patch,
> HBASE-16981.master.004.patch,
> Supportingweeklyandmonthlymobcompactionpartitionpolicyinhbase.pdf
>
>
> Today the mob region holds all mob files for all regions. With daily
> partition mob compaction policy, after major mob compaction, there is still
> one file per region daily. Given there is 365 days in one year, at least 365
> files per region. Since HDFS has limitation for number of files under one
> folder, this is not going to scale if there are lots of regions. To reduce
> mob file number, we want to introduce other partition policies such as
> weekly, monthly to compact mob files within one week or month into one file.
> This jira is create to track this effort.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
